Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move back to bytes32 (instead of uint256) for tableIds #484

Closed
holic opened this issue Mar 13, 2023 · 1 comment
Closed

move back to bytes32 (instead of uint256) for tableIds #484

holic opened this issue Mar 13, 2023 · 1 comment
Assignees
@alvrs

Comments

@holic
Copy link
Member

holic commented Mar 13, 2023

Casting between uint256 and bytes32 for table IDs is scary because strings are left-aligned (right zero padded) and numbers are right-aligned (left zero padded), and I've had to carefully work around this in #415 (comment)
This was referenced Mar 13, 2023
Merged
Open
@holic
Copy link
Member Author

holic commented Apr 17, 2023

done in #613

@holic holic closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvrs alvrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holic @alvrs