Use fixtures outside ./fixtures/

[ripa1995]

Is your feature request related to a problem? Please describe.
In big projects, with a lot of integration tests, it happens that the same fixture needs to be used in multiple tests which are structured in sub folders, leading to duplicated ./fixtures/ files.

Describe the solution you'd like
It would be nice to have the possibility to specify a path to the fixture script (e.g., ../fixtures/users), other than the name of the fixture script (as it is now), leading to something like: #[sqlx::test(fixtures("../other_dir/fixtures/users", "posts"))].

Describe alternatives you've considered
An alternative could be to accept also fixtures_with_path, e.g. #[sqlx::test(fixtures_with_path("../other_dir/fixtures/users"), fixtures("posts"))].

Additional context
None.

I would like to help on that one, if needed ofc.

[abonander]

That sounds like an improvement, yeah. The code for the #[test] attribute is here: https://github.com/launchbadge/sqlx/blob/main/sqlx-macros-core/src/test_attr.rs

I would name it fixtures_path though.

[ripa1995]

That sounds like an improvement, yeah. The code for the #[test] attribute is here: https://github.com/launchbadge/sqlx/blob/main/sqlx-macros-core/src/test_attr.rs

I would name it fixtures_path though.

Thanks.

I will start to work on that tomorrow. It should not take too much time.

[ripa1995]

@abonander, I've started to do it https://github.com/runtime-machines/sqlx/blob/2539-expand-fixtures/sqlx-macros-core/src/test_attr.rs .

I think it is better to accept only one between fixtures and fixtures_path, like for migrations and migrator. This mostly to avoid issues with the execution order. I have also modified one test such that it uses fixtures from an outer directory.

Another possibility is:

• accept only fixtures.
• fixtures field in Args as Vec<LitStr>.
• in parse_args check if fixture is a path or not, and format it directly with format!("fixtures/{}.sql", fixture.value()) or format!("{}.sql", fixture.value()).
• in expand_advanced treat everything as before, without the formatting of the fixtures values.

[abonander]

#2545 (comment)