Skip to content

Latest commit

 

History

History
69 lines (45 loc) · 3.65 KB

CONTRIBUTING.md

File metadata and controls

69 lines (45 loc) · 3.65 KB
Raw

Contributing to this project

Submitting bug reports and feature requests

The LaunchDarkly SDK team monitors the issue tracker in tis repository. Bug reports and feature requests specific to this project should be filed in this issue tracker. The SDK team will respond to all newly filed issues within two business days.

Submitting pull requests

We encourage pull requests and other contributions from the community. Before submitting pull requests, ensure that all temporary or unintended code is removed. Don't worry about adding reviewers to the pull request; the LaunchDarkly SDK team will add themselves. The SDK team will acknowledge all pull requests within two business days.

Build instructions

Prerequisites

This project should be built against the lowest supported Go version as described in README.md.

Building

To build the project without running any tests:

make

If you wish to clean your working directory between builds, you can clean it by running:

make clean

To run the linter:

make lint

Testing

To build and run all unit tests, for the default implementation and also the easyjson implementation:

make test
make test-easyjson

To run benchmarks:

make benchmarks
make benchmarks-easyjson

Coding best practices

Test coverage

It is important to keep unit test coverage as close to 100% as possible in this project. You can generate this information locally with make test-coverage.

The build will fail if there are any uncovered blocks of code, unless you explicitly add an override by placing a comment that starts with // COVERAGE somewhere within that block. Sometimes a gap in coverage is unavoidable, usually because the compiler requires us to provide a code path for some condition that in practice can't happen and can't be tested. Exclude these paths with a // COVERAGE comment.

Avoid heap allocations

For performance and to avoid unwanted heap churn, it is highly desirable to avoid allocating data on the heap if it could instead be passed as a value type.

Go's memory model uses a mix of stack and heap allocations, with the compiler transparently choosing the most appropriate strategy based on various type and scope rules. It is always preferable, when possible, to keep ephemeral values on the stack rather than on the heap to avoid creating extra work for the garbage collector.

  • The most obvious rule is that anything explicitly allocated by reference (x := &SomeType{}), or returned by reference (return &x), will be allocated on the heap. Avoid this unless the object has mutable state that must be shared.
  • Casting a value type to an interface causes it to be allocated on the heap, since an interface is really a combination of a type identifier and a hidden pointer.
  • A closure that references any variables outside of its scope (including the method receiver, if it is inside a method) causes an object to be allocated on the heap containing the values or addresses of those variables.
  • Treating a method as an anonymous function (myFunc := someReceiver.SomeMethod) is equivalent to a closure.

Allocations are counted in the benchmark output: "5 allocs/op" means that a total of 5 heap objects were allocated during each run of the benchmark. This does not mean that the objects were retained, only that they were allocated at some point.

For methods that should be guaranteed not to do any heap allocations, the corresponding benchmarks should have names ending in NoAlloc. The make benchmarks target will automatically fail if allocations are detected in any benchmarks that have this name suffix.