fix: add support for testing minimum Go version #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-launchdarkly
approved these changes
Aug 20, 2024
cwaldren-ld
changed the title
cwaldren-ld
pushed a commit
that referenced
this pull request
Aug 20, 2024
🤖 I have created a release *beep* *boop* --- ## [6.2.1](v6.2.0...v6.2.1) (2024-08-20) ### Bug Fixes * add support for testing minimum Go version ([#172](#172)) ([37483bc](37483bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Port from v7.)
This PR relaxes the minimum compiler version to 1.18, as the only new feature we were using was the standard library slices package. This can be replaced with
x/exp/slices.To test the minimum version, I've added a new key/value to
go-versions.env. This version is now tested in CI, and can be easily bumped usingmake bump-min-go-version MIN_GO_VERSION=foo.Finally, I've updated our documentation to clarify our support policy.