Merge branch 'eb/ch76240/benchmarks-4.x' into eb/ch76240/benchmarks-4.x-report

Author: eli-darkly

benchmarks/src/jmh/java/com/launchdarkly/sdk/server/EventProcessorBenchmarks.java

@@ -5,7 +5,6 @@
 import com.launchdarkly.client.EventProcessor;
 import com.launchdarkly.client.EventProcessorInternals;
 import com.launchdarkly.client.LDConfig;
-import com.launchdarkly.client.LDUser;
 import com.launchdarkly.client.interfaces.EventSender;
 import com.launchdarkly.client.interfaces.EventSenderFactory;
 import com.launchdarkly.client.interfaces.HttpConfiguration;
@@ -17,8 +16,14 @@
 
 import java.io.IOException;
 import java.net.URI;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Random;
 
+import static com.launchdarkly.sdk.server.TestValues.BASIC_USER;
+import static com.launchdarkly.sdk.server.TestValues.CUSTOM_EVENT;
+import static com.launchdarkly.sdk.server.TestValues.TEST_EVENTS_COUNT;
+
 public class EventProcessorBenchmarks {
   private static final int EVENT_BUFFER_SIZE = 1000;
   private static final int FLAG_COUNT = 10;
@@ -30,7 +35,8 @@ public static class BenchmarkInputs {
     // Initialization of the things in BenchmarkInputs does not count as part of a benchmark.
     final EventProcessor eventProcessor;
     final EventSender eventSender;
-    final LDUser basicUser;
+    final List<Event.FeatureRequest> featureRequestEventsWithoutTracking = new ArrayList<>();
+    final List<Event.FeatureRequest> featureRequestEventsWithTracking = new ArrayList<>();
     final Random random;
 
     public BenchmarkInputs() {
@@ -44,9 +50,30 @@ public BenchmarkInputs() {
           .eventSender(new MockEventSenderFactory())
           .createEventProcessor(TestValues.SDK_KEY, new LDConfig.Builder().build());
 
-      basicUser = new LDUser("userkey");
-
       random = new Random();
+      
+      for (int i = 0; i < TEST_EVENTS_COUNT; i++) {
+        String flagKey = "flag" + random.nextInt(FLAG_COUNT);
+        int version = random.nextInt(FLAG_VERSIONS) + 1;
+        int variation = random.nextInt(FLAG_VARIATIONS);
+        for (boolean trackEvents: new boolean[] { false, true }) {
+          Event.FeatureRequest event = new Event.FeatureRequest(
+              System.currentTimeMillis(),
+              flagKey,
+              BASIC_USER,
+              version,
+              variation,
+              LDValue.of(variation),
+              LDValue.ofNull(),
+              null,
+              null,
+              trackEvents,
+              null,
+              false
+              );
+          (trackEvents ? featureRequestEventsWithTracking : featureRequestEventsWithoutTracking).add(event);
+        }
+      }
     }
 
     public String randomFlagKey() {
@@ -64,22 +91,7 @@ public int randomFlagVariation() {
 
   @Benchmark
   public void summarizeFeatureRequestEvents(BenchmarkInputs inputs) throws Exception {
-    for (int i = 0; i < 1000; i++) {
-      int variation = inputs.randomFlagVariation();
-      Event.FeatureRequest event = new Event.FeatureRequest(
-          System.currentTimeMillis(),
-          inputs.randomFlagKey(),
-          inputs.basicUser,
-          inputs.randomFlagVersion(),
-          variation,
-          LDValue.of(variation),
-          LDValue.ofNull(),
-          null,
-          null,
-          false, // trackEvents == false: only summary counts are generated
-          null,
-          false
-          );
+    for (Event.FeatureRequest event: inputs.featureRequestEventsWithoutTracking) {
       inputs.eventProcessor.sendEvent(event);
     }
     inputs.eventProcessor.flush();
@@ -88,22 +100,7 @@ public void summarizeFeatureRequestEvents(BenchmarkInputs inputs) throws Excepti
 
   @Benchmark
   public void featureRequestEventsWithFullTracking(BenchmarkInputs inputs) throws Exception {
-    for (int i = 0; i < 1000; i++) {
-      int variation = inputs.randomFlagVariation();
-      Event.FeatureRequest event = new Event.FeatureRequest(
-          System.currentTimeMillis(),
-          inputs.randomFlagKey(),
-          inputs.basicUser,
-          inputs.randomFlagVersion(),
-          variation,
-          LDValue.of(variation),
-          LDValue.ofNull(),
-          null,
-          null,
-          true, // trackEvents == true: the full events are included in the output
-          null,
-          false
-          );
+    for (Event.FeatureRequest event: inputs.featureRequestEventsWithTracking) {
       inputs.eventProcessor.sendEvent(event);
     }
     inputs.eventProcessor.flush();
@@ -112,16 +109,8 @@ public void featureRequestEventsWithFullTracking(BenchmarkInputs inputs) throws
 
   @Benchmark
   public void customEvents(BenchmarkInputs inputs) throws Exception {
-    LDValue data = LDValue.of("data");
-    for (int i = 0; i < 1000; i++) {
-      Event.Custom event = new Event.Custom(
-          System.currentTimeMillis(),
-          "event-key",
-          inputs.basicUser,
-          data,
-          null
-          );
-      inputs.eventProcessor.sendEvent(event);;
+    for (int i = 0; i < TEST_EVENTS_COUNT; i++) {
+      inputs.eventProcessor.sendEvent(CUSTOM_EVENT);
     }
     inputs.eventProcessor.flush();
     EventProcessorInternals.waitUntilInactive(inputs.eventProcessor);

benchmarks/src/jmh/java/com/launchdarkly/sdk/server/TestValues.java

@@ -1,5 +1,6 @@
 package com.launchdarkly.sdk.server;
 
+import com.launchdarkly.client.Event;
 import com.launchdarkly.client.LDUser;
 import com.launchdarkly.client.value.LDValue;
 
@@ -11,6 +12,8 @@ private TestValues() {}
 
   public static final String SDK_KEY = "sdk-key";
 
+  public static final LDUser BASIC_USER = new LDUser("userkey");
+  
   public static final String BOOLEAN_FLAG_KEY = "flag-bool";
   public static final String INT_FLAG_KEY = "flag-int";
   public static final String STRING_FLAG_KEY = "flag-string";
@@ -49,4 +52,16 @@ private TestValues() {}
       new LDUser.Builder("key").custom(CLAUSE_MATCH_ATTRIBUTE, NOT_MATCHED_VALUE).build();
 
   public static final String EMPTY_JSON_DATA = "{\"flags\":{},\"segments\":{}}";
+  
+  public static final int TEST_EVENTS_COUNT = 1000;
+  
+  public static final LDValue CUSTOM_EVENT_DATA = LDValue.of("data");
+  
+  public static final Event.Custom CUSTOM_EVENT = new Event.Custom(
+      System.currentTimeMillis(),
+      "event-key",
+      BASIC_USER,
+      CUSTOM_EVENT_DATA,
+      null
+      );
 }