docs: Fix version generation in PROVENANCE file #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Mar 1, 2024
| @@ -7,26 +7,32 @@ As part of [SLSA requirements for level 3 compliance](https://slsa.dev/spec/v1.0 | |||
| To verify SLSA provenance attestations, we recommend using [slsa-verifier](https://github.com/slsa-framework/slsa-verifier). Example usage for verifying SDK packages is included below: | |||
|
|
|||
| <!-- x-release-please-start-version --> | |||
| ``` | |||
There was a problem hiding this comment.
@rsoberano-ld here is the fix for the release please version replacement problem we saw in the currently pending release.
Look okay to you?
There was a problem hiding this comment.
Nice, this looks like it should work nicely! Thanks for the fix
rsoberano-ld
approved these changes
Mar 1, 2024
keelerm84
pushed a commit
that referenced
this pull request
Mar 1, 2024
🤖 I have created a release *beep* *boop* --- ## [9.2.1](9.2.0...9.2.1) (2024-03-01) ### Bug Fixes * Raise minimum urllib3 package to 1.26.0 ([#271](#271)) ([ffeded9](ffeded9)), closes [#270](#270) ### Documentation * Add example output for PROVENANCE.md [#268](#268) ([43cf5bf](43cf5bf)) * Fix version generation in PROVENANCE file ([#272](#272)) ([7dd887e](7dd887e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.