Skip to content

Commit 275b005

Browse files
authored
identify should not emit events if user key is "" (#181)
1 parent 64b2549 commit 275b005

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/ldclient-rb/ldclient.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,8 @@ def variation_detail(key, user, default)
248248
# @return [void]
249249
#
250250
def identify(user)
251-
if !user || user[:key].nil?
252-
@config.logger.warn("Identify called with nil user or nil user key!")
251+
if !user || user[:key].nil? || user[:key].empty?
252+
@config.logger.warn("Identify called with nil user or empty user key!")
253253
return
254254
end
255255
sanitize_user(user)

spec/ldclient_events_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,13 +196,13 @@ def event_processor(client)
196196
end
197197
end
198198

199-
it "does not send event, and logs warning, if user key is nil" do
199+
it "does not send event, and logs warning, if user key is blank" do
200200
logger = double().as_null_object
201201

202202
with_client(test_config(logger: logger)) do |client|
203203
expect(event_processor(client)).not_to receive(:add_event)
204204
expect(logger).to receive(:warn)
205-
client.identify({ key: nil })
205+
client.identify({ key: "" })
206206
end
207207
end
208208
end

0 commit comments

Comments
 (0)