Skip to content

Commit 6308826

Browse files
authored
chore: Use gh-actions/actions/persistent-stores (#335)
The latest consul image incorrectly handles a '$' in the key name. This is causing failing tests since we use an '$inited' key. Until the consul change is remedied, we need to pin to a working version of consul. This is already done in our shared GH action for persistent stores, so I am updating this SDK to finally use that.
1 parent 5ac41e0 commit 6308826

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

.github/workflows/build-gem.yml

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,23 +22,15 @@ jobs:
2222
BUILD_PLATFORM: ${{ startsWith(inputs.version, 'jruby') && 'jruby' || 'ruby' }}
2323
FLAKY: ${{ startsWith(inputs.version, 'jruby') && 'true' || 'false' }}
2424

25-
services:
26-
redis:
27-
image: redis
28-
ports:
29-
- 6379:6379
30-
dynamodb:
31-
image: amazon/dynamodb-local
32-
ports:
33-
- 8000:8000
34-
consul:
35-
image: hashicorp/consul
36-
ports:
37-
- 8500:8500
38-
3925
steps:
4026
- uses: actions/checkout@v4
4127

28+
- uses: launchdarkly/gh-actions/actions/persistent-stores@persistent-stores-v0
29+
with:
30+
redis: true
31+
consul: true
32+
dynamodb: true
33+
4234
- uses: ./.github/actions/setup
4335
with:
4436
version: ${{ inputs.version }}

spec/ldclient_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ module LaunchDarkly
113113
prereq = flags_map[prereq[:key].to_sym]
114114
prereq_index = flags_list.index(prereq)
115115
if prereq_index > item_index
116-
all_keys = (flags_list.map { |f| f[:key] }).join(", ")
116+
all_keys = flags_list.map { |f| f[:key] }.join(", ")
117117
raise "#{item[:key]} depends on #{prereq[:key]}, but #{item[:key]} was listed first; keys in order are [#{all_keys}]"
118118
end
119119
end

0 commit comments

Comments
 (0)