Skip to content

Commit f1fb72a

Browse files
committed
Merge pull request #55 from launchdarkly/pk/send-default
send sdk default value with flag request events
2 parents 71ea5eb + 01c3b05 commit f1fb72a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/ldclient-rb/ldclient.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def toggle?(key, user, default = false)
147147
value = evaluate(feature, user)
148148
value = value.nil? ? default : value
149149

150-
add_event(kind: "feature", key: key, user: user, value: value)
150+
add_event(kind: "feature", key: key, user: user, value: value, default: default)
151151
LDNewRelic.annotate_transaction(key, value)
152152
return value
153153
rescue StandardError => error

spec/ldclient_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,10 @@
7676
result = client.toggle?(feature[:key], user, "default")
7777
expect(result).to eq "default"
7878
end
79+
it "will specify the default value in the feature request event" do
80+
expect(client).to receive(:add_event).with(hash_including(default: "default"))
81+
result = client.toggle?(feature[:key], user, "default")
82+
end
7983
it "requires user" do
8084
expect(client.instance_variable_get(:@config).logger).to receive(:error)
8185
result = client.toggle?(feature[:key], nil, "default")

0 commit comments

Comments
 (0)