-
Notifications
You must be signed in to change notification settings - Fork 55
feat: Add experimental plugin support #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Add Plugin interface and metadata classes following plugin specs - Extend Config class to accept plugins parameter - Modify LDClient to register plugins and collect their hooks - Add comprehensive tests for plugin functionality - Follow existing Ruby SDK patterns and conventions Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
keelerm84
approved these changes
Jul 15, 2025
Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it. |
keelerm84
approved these changes
Jul 15, 2025
jsonbailey
pushed a commit
that referenced
this pull request
Jul 15, 2025
🤖 I have created a release *beep* *boop* --- ## [8.11.0](8.10.2...8.11.0) (2025-07-15) ### Features * Add experimental plugin support ([#327](#327)) ([1bdcf01](1bdcf01)) ### Bug Fixes * Bump eventsource to 2.2.6 ([#331](#331)) ([33feb9b](33feb9b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add experimental plugin support
Summary
This PR implements experimental plugin support for the Ruby Server SDK following the LaunchDarkly plugin specifications. The implementation adds a new Plugin interface that allows external integrations to register hooks and perform initialization tasks during SDK startup.
Key Changes:
Interfaces::Plugins
module with Plugin mixin and metadata classes (SdkMetadata
,ApplicationMetadata
,EnvironmentMetadata
,PluginMetadata
)Config
class to accept and validateplugins
parameterLDClient
to collect plugin hooks during initialization and register plugins after data source setupMockPlugin
test utility following existing patternsImplementation Details:
Review & Testing Checklist for Human
get_hooks()
andregister()
are caught and logged without breaking SDK initializationRecommended Test Plan:
Diagram
Notes