Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repetition in home.js. Two functions with same output. #127

Open
ghost opened this issue Feb 13, 2017 · 0 comments
Open

Repetition in home.js. Two functions with same output. #127

ghost opened this issue Feb 13, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 13, 2017

retrieveSelectedModuleTitle(){
var userModules = this.state.userModules;
var modules = moduleplan.degree_course.modules;
var selectedModuleIds = [];
var selectedModuleTitles = [];
for (var i = 0; i < userModules.length; i++) {
if (userModules[i].selected){
selectedModuleIds.push(userModules[i].module_id);
}
}
for (var i = 0; i < selectedModuleIds.length; i++) {
for (var j=0; j < modules.length; j++){
if (selectedModuleIds[i] === modules[j].id) {
selectedModuleTitles.push(modules[j].title);
}
}
}
return selectedModuleTitles;
};

retrieveSelectedModules(){
var userModules = this.state.userModules;
var modules = moduleplan.degree_course.modules;
var selectedModuleIds = [];
var selectedModuleTitles = [];
for (var i = 0; i < userModules.length; i++) {
if (userModules[i].selected){
selectedModuleIds.push(userModules[i].module_id);
}
}
for (var i = 0; i < selectedModuleIds.length; i++) {
for (var j=0; j < modules.length; j++){
if (selectedModuleIds[i] === modules[j].id) {
modules[j].module_id = selectedModuleIds[i];
selectedModuleTitles.push(modules[j]);
}
}
}
return selectedModuleTitles;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants