Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom headers #5

Closed
laurencelundblade opened this issue Nov 19, 2019 · 4 comments
Closed

Support custom headers #5

laurencelundblade opened this issue Nov 19, 2019 · 4 comments
Labels
enhancement New feature or request For t_cose 2.0

Comments

@laurencelundblade
Copy link
Owner

Be able to add arbitrary headers when encoding and be able to call out to custom decoder when encountering an unknown header.

@letmaik
Copy link
Contributor

letmaik commented Mar 9, 2022

I'm interested in custom headers specifically for decoding. How much would it take to support this?

@laurencelundblade laurencelundblade added the enhancement New feature or request label Apr 25, 2022
@letmaik
Copy link
Contributor

letmaik commented Jan 23, 2023

@laurencelundblade How much of this is implemented in the develop branch already? Is it just the string label support that's missing?
cc @plietar

@laurencelundblade
Copy link
Owner Author

Custom headers is largely complete and in good shape in the dev branch. I'm happy with the design and implementation.

It does not support string labels, but adding that should be straight forward.

But, what's there is possibly not the path for counter signatures because the call backs don't have access to the signer inputs. I think a new type of signer object is the way to go for counter sigs.

The signer objects are also in fairly good shape except for the verification of multiple signatures. I'm kind of working on that now (in parallel with a lot of other stuff).

@laurencelundblade
Copy link
Owner Author

Fixed by #78 and other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request For t_cose 2.0
Projects
None yet
Development

No branches or pull requests

2 participants