Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: Autocorrect inserts 2 line breaks. #10043

Closed
itzTheMeow opened this issue Mar 4, 2024 · 7 comments · Fixed by #10174
Closed

iOS: Autocorrect inserts 2 line breaks. #10043

itzTheMeow opened this issue Mar 4, 2024 · 7 comments · Fixed by #10174
Labels
bug It's a bug editor iOS upstream There's a problem with upstream code.

Comments

@itzTheMeow
Copy link
Contributor

Operating system

iOS

Joplin version

12.14.6

Desktop version info

No response

Current behaviour

When typing in the note editor and the last word on the line is spelled incorrectly (autocorrect) pressing return inserts 2 line breaks and does not autocorrect the word
Screen recording explains it better

RPReplay_Final1709528663.mov

Expected behaviour

Instead of inserting 2 new lines it should autocorrect the word and insert 1 new line

Logs

No response
@itzTheMeow itzTheMeow added the bug It's a bug label Mar 4, 2024
@itzTheMeow
Copy link
Contributor Author

Not sure if this is a CodeMirror problem.

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Mar 4, 2024 •
edited
Loading

What version of iOS are you using?

Edit: I can reproduce this on iOS 17.3.1. I suspect it's a CodeMirror issue -- I'm posting a link to a CodeMirror demo that may help verify this.

@itzTheMeow
Copy link
Contributor Author

yep, iOS 17.3.1 on an iPhone 12

@itzTheMeow
Copy link
Contributor Author

Yes also seems to be same behavior on the demo page. I'll create a code mirror issue. Should this one stay open?

@itzTheMeow
Copy link
Contributor Author

codemirror/dev#1349

@personalizedrefrigerator personalizedrefrigerator added the upstream There's a problem with upstream code. label Mar 4, 2024
@personalizedrefrigerator
Copy link
Collaborator

Should this one stay open?

Yes, please keep this issue open.

@itzTheMeow
Copy link
Contributor Author

Looks like it's fixed, just waiting for the author to tag a version.

@itzTheMeow itzTheMeow mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug editor iOS upstream There's a problem with upstream code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

All: Bump @codemirror/view version.
2 participants
@personalizedrefrigerator @itzTheMeow