Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert of Revert should be credited too #94

Closed
claudiu-cristea opened this issue Dec 31, 2016 · 1 comment
Closed

Revert of Revert should be credited too #94

claudiu-cristea opened this issue Dec 31, 2016 · 1 comment

Comments

@claudiu-cristea
Copy link

claudiu-cristea commented Dec 31, 2016

Look at this commit https://www.drupal.org/commitlog/commit/2/83018b7596ab807148acc9d45b6ffef572eb61bf. The patch was committed, then reverted, then committed back. But the last commit was a "revert of the revert" with the message:

Revert "Revert "Issue #2834291 by claudiu.cristea, Berdir, amateescu, timmillwood, catch: Add a SQL index for entity types that are using EntityPublishedInterface""

Because of https://github.com/lauriii/drupalcores/blob/master/app/bin/json.rb#L16, the developers and reviewers from this issue were not credited.

@claudiu-cristea
Copy link
Author

Closing in favour of #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant