Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing selected value on Android #414

Open
matobiely opened this issue Jan 19, 2021 · 16 comments
Open

Not showing selected value on Android #414

matobiely opened this issue Jan 19, 2021 · 16 comments

Comments

@matobiely
Copy link

Describe the bug

I am using picker-select in form for creating/editing notes. I am fetching items from our API.

First issue is with create note:

  • Open picker, can see all items
  • Select item
  • item label is not shown in select field
  • if i save note, it is created with correct category

Issue with edit:

  • click on edit
  • do not see label
  • can select different item, but after select, do not see label in field

It works fine only if i have items array locally ( not acceptable) and also default value is set to value from items, which is problem for creating new, because default is null. Also it is not accepting default value from props (as can be seen in code snipet)

On iPhone works just fine, only Android issue.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

I expected the same behavior as on iPhone.

Screenshots

  1. Empty new form

image

  1. Show all items

image

  1. Select picker after select one of the items

image

Additional details

  • Device: [Pixel 3]
  • OS: [Android 11]
  • react-native-picker-select version: [8.04]
  • react-native version: [0.63]
  • expo sdk version: [40]

Reproduction and/or code sample

function NewNote({ t, note: _note, loading, onSubmit, onCancel }) {
  const [note, setNote] = useState(_note);
  const [categories, setCategories] = useState([]);
  const [categoryId, setCategoryId] = (_note && _note.categoryId );

  const handleSubmit = async () => {
    await onSubmit(note);
    setNote(null);
    onCancel();
  };

  const loadCategories = async () => {
    const res = await axios('categories/autocompletes', {
      params: {
        params: { perPage: 9999 },
        filters: [
          {
            by: 'categoryType',
            rule: 'equal',
            value: 'Note'
          }
        ]
      }
    });

    setCategories(
      res.data.categories.map(c => ({
        value: c.id,
        label: c.name
      }))
    );
  };

  const handleNoteTypeChange = value => {
    if (!value) return;
    setCategoryId(value);
    setNote({ ...note, categoryId: value });
  };

  useEffect(() => {
    loadCategories();
  }, []);

  return (
           <RNPickerSelect
            value={note && note.categoryId}
            onValueChange={handleNoteTypeChange}
            style={_pickerStyles}
            placeholder={{ label: 'Type', value: null }}
            items={categories}
          />
)
@EmmanuelSkapple
Copy link

Same error to :/

@KIMNIGANG
Copy link

same error too

1 similar comment
@guozhaolong
Copy link

same error too

@iwashi1t
Copy link

As a temporary workaround, I found two solutions.

Set one of the following prop to RNPickerSelect,

  • style={{ inputAndroid: { color: 'black' } }}
  • useNativeAndroidPickerStyle={false}

@guozhaolong
Copy link

As a temporary workaround, I found two solutions.

Set one of the following prop to RNPickerSelect,

  • style={{ inputAndroid: { color: 'black' } }}
  • useNativeAndroidPickerStyle={false}

verified, inputAndroid: {color:'black' } this trick is easy to use,thx bro

@matobiely
Copy link
Author

matobiely commented Jan 22, 2021

@iwashi1t Thanks. It helps. But as you mentioned, it is just temporary workaround, it will be great, if somebody from team take a look on it.

@iggirex
Copy link

iggirex commented Feb 5, 2021

After many hours of twiddling with this thing finally found this thread. Low and behold this indeed does fix the problem!!
style={{ inputAndroid: { color: 'black' } }} useNativeAndroidPickerStyle={false}

My other solution was to set the placeholder as empty object, but this screws up the layout if you're needing that placeholder
placeholder={{}}

@Tharinducn
Copy link

As a temporary workaround, I found two solutions.

Set one of the following prop to RNPickerSelect,

  • style={{ inputAndroid: { color: 'black' } }}
  • useNativeAndroidPickerStyle={false}

This didn't fix the issue.

@imsjmalve
Copy link

style={{ inputAndroid: { color: 'black' } }}
useNativeAndroidPickerStyle={false}

these two perfectly works for me

@dschnare
Copy link

I'm having this issue with iOS actually. Tried setting styles for inputIOS with no dice.

const pickerStyles = StyleSheet.create({
  inputIOS: {
    fontSize: 16,
    paddingVertical: 12,
    paddingHorizontal: 10,
    borderWidth: 1,
    borderColor: 'gray',
    borderRadius: 4,
    color: 'black',
    paddingRight: 30 // to ensure the text is never behind the icon
  },
  inputAndroid: {
    fontSize: 16,
    paddingHorizontal: 10,
    paddingVertical: 8,
    borderWidth: 0.5,
    borderColor: 'purple',
    borderRadius: 8,
    color: 'black',
    paddingRight: 30 // to ensure the text is never behind the icon
  }
})
<PickerSelect
  disabled={isSaving}
  Icon={Chevron}
  style={pickerStyles}
  placeholder={{}}
  items={items}
  value={value}
  onValueChange={(value) => setValue(value)}
  useNativeAndroidPickerStyle={false}
  textInputProps={{ style: { borderRadius: 5 } }}
/>

@imsjmalve
Copy link

imsjmalve commented Feb 26, 2021

u said useNativeAndroidPickerStyle={false}, find another for iso

@ubay1
Copy link

ubay1 commented Mar 20, 2021

const [selectedLanguage, setSelectedLanguage] = useState('');

<RNPickerSelect
useNativeAndroidPickerStyle={false}
value={selectedLanguage}
onValueChange={(itemValue) => {
setSelectedLanguage(itemValue)
}}
items={[
{ label: 'Football', value: 'football' },
{ label: 'Baseball', value: 'baseball' },
{ label: 'Hockey', value: 'hockey' },
]} >
{selectedLanguage }

@ubay1
Copy link

ubay1 commented Mar 20, 2021

hey, lets try..

@EvgeniiKlepilin
Copy link

One thing that I found was that if you have a default Android Theme, it usually has a default application-wide font color set to #ffffff. You can change that by either adding a custom font color to existing theme, or changing parent theme to themes like MaterialDark or Holo for example.

android/app/src/main/res/values/styles.xml

    <!-- Base application theme. -->
    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
        <!-- Customize your theme here. -->
        <item name="android:textColor">#000000</item>
        <item name="android:statusBarColor">@color/black</item>
    </style>

android/app/src/main/AndroidManifest.xml

    <application
      android:name=".MainApplication"
      android:label="@string/app_name"
      android:icon="@mipmap/ic_launcher"
      android:roundIcon="@mipmap/ic_launcher"
      android:theme="@style/AppTheme">

References:

It seems that there are some native parts of this package that can be changed by tweaking details of the manifest.

@Saurabhreactninja
Copy link

style={{ inputAndroid: { color: 'black' } }}
useNativeAndroidPickerStyle={false}

these two perfectly works for me

Which version of picker_select you are using ?

@JedrzejMajko
Copy link

Regarding iOS and Android I encounter similar issue when padding (in inputIOS or )inputAndroid was set to large number, like 20 on ios 14 or lower. on ios 15 vertical padding of 20+ didn't cause same issue.
So this can also be a styling issue coming from label being out of view.

This is iOS 14 with inputIOS.paddingVertical 10:
Screenshot 2022-04-11 at 11 38 21

This is iOS 14 with inputIOS.paddingVertical 18:
Screenshot 2022-04-11 at 11 38 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests