Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participants in group chat are unable to use Aiden #5

Closed
ghost opened this issue Jan 19, 2018 · 4 comments
Closed

Participants in group chat are unable to use Aiden #5

ghost opened this issue Jan 19, 2018 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 19, 2018

The participants in the group chat are unable to use Aiden, if they are not friends yet with Aiden.
Is this a bug? Thanks.

@laymonage
Copy link
Owner

I'm not really sure about this, but it seems that it's because bots can't read chat messages from someone who hasn't accepted the agreement with the bot's provider (me). If I recall correctly, LINE shows a dialog box about this the first time someone adds a bot from a new provider, prompting them to either Agree or Disagree.

@ghost
Copy link
Author

ghost commented Jan 22, 2018

No, I don't have that box pop up for me or my friends. It's unexpected because a bot like "Kerang Ajaib" was able to operate just fine, without having to first add the bot ("Kerang Ajaib" is gone now, so this is about 2 months ago).

@laymonage
Copy link
Owner

laymonage commented Jan 22, 2018

You're right. It seems that the dialog box doesn't always appear. It does appear on LINE Lite and PC LINE, though.

I've been aware of this issue since I initially developed Aiden, but I wasn't sure why, and I've nailed the problem just now. It turns out that the get_profile method only works if the user has added Aiden. If the user hasn't added him, different methods (get_group_member_profile and get_room_member_profile) need to be used.

I've pushed a commit (a3e289c) that fixes this. Can you please test it again? Thanks!

@laymonage laymonage reopened this Jan 22, 2018
@laymonage laymonage added the bug label Jan 22, 2018
@ghost
Copy link
Author

ghost commented Jan 22, 2018

Ok, my friends have confirmed the fix. Thanks.

@ghost ghost closed this as completed Jan 22, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant