Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test:lock script #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: test:lock script #13

wants to merge 4 commits into from

Conversation

LZHK1ng
Copy link
Contributor

@LZHK1ng LZHK1ng commented Oct 19, 2022

What this PR does:
add a test:lock script
Which issue(s) this PR fixes:
Fixes #12

@seeflood seeflood requested a review from fengmk2 October 19, 2022 06:59
@@ -14,6 +14,7 @@
"test": "jest --detectOpenHandles",
"test:unit": "NODE_ENV=test npm run test 'test/unit/.*\\.test\\.ts'",
"test:demo": "cd demo && npm run test:all",
"test:lock": "cd demo && npm run test:lock",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I still failed in my local machine.

cd js-sdk/demo
npm install 

The error message:
image

Copy link
Contributor Author

@LZHK1ng LZHK1ng Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you can try it
cd js-sdk
npm install

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LZHK1ng Then npm install succeeds but npm run test:lock fails:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, The original approach worked in my machine.But it failed in CI😢.I try to use yarn install to fix it.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still failed on my laptop:

cd demo
yarn install

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add test:lock script
2 participants