Fix nasty append bug that caused 'min' namespace id modifications #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 94.70% 94.77% +0.06%
==========================================
Files 7 7
Lines 302 306 +4
==========================================
+ Hits 286 290 +4
Misses 11 11
Partials 5 5
Continue to review full report at Codecov.
|
liamsi
reviewed
Mar 29, 2021
Comment on lines
+43
to
+47
| return append(append(append( | ||
| make([]byte, 0, len(d.min)*2+len(d.digest)), | ||
| d.min...), | ||
| d.max...), | ||
| d.digest...) |
There was a problem hiding this comment.
@adlerjohn will love this one 🤣
Note that differently from the title, the nid does not get modified. Still the race detector would raise an alarm here before as this is seen as a WRITE.
liamsi
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
celestiaorg/celestia-core#248 (comment)