Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final keyword disregarded #418

Open
2 tasks
AntoineGautier opened this issue Dec 17, 2024 · 0 comments
Open
2 tasks

Final keyword disregarded #418

AntoineGautier opened this issue Dec 17, 2024 · 0 comments
Labels
bug Something isn't working Top Priority Top of the Priority List

Comments

@AntoineGautier
Copy link
Collaborator

AntoineGautier commented Dec 17, 2024

With

  • commit eea5ab9 of ctrl-flow (current main)
  • commit b3f5c3ffd7 of MBL

the final keyword is disregarded for the parameter secOutRel.typCtlEco.
This parameter should not appear in the configuration panel due to the following binding in Buildings.Templates.AirHandlersFans.VAVMultiZone.

  inner replaceable Buildings.Templates.AirHandlersFans.Components.OutdoorReliefReturnSection.MixedAirWithDamper
    secOutRel(...
    final typCtlEco=ctl.typCtlEco,

This is not a regression: we can verify that with older commits of ctrl-flow (e.g. 99776d3) the problem already existed.

There is currently a patch in MBL master for such basic constructs where a parameter is declared in a base class and assigned a final value when instantiating the derived class.
For instance, in Buildings.Templates.AirHandlersFans.Components.Interfaces.PartialOutdoorReliefReturnSection we have:

  parameter Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer typCtlEco=
    Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer.FixedDryBulb
    "Economizer control type"
    annotation (__ctrlFlow(enable=false),

This explains the difference in the UI between the MBL master and commit b3f5c3ffd7.

TODO:

  • Implement the logic to detect final modifiers using ctrl-flow, in accordance with MSL rules.
  • Once this issue is resolved, refactor MBL templates to eliminate all __ctrlFlow(enable=false) annotations that are no longer required.
@AntoineGautier AntoineGautier added bug Something isn't working Top Priority Top of the Priority List labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Top Priority Top of the Priority List
Projects
None yet
Development

No branches or pull requests

1 participant