You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the final keyword is disregarded for the parameter secOutRel.typCtlEco.
This parameter should not appear in the configuration panel due to the following binding in Buildings.Templates.AirHandlersFans.VAVMultiZone.
innerreplaceable Buildings.Templates.AirHandlersFans.Components.OutdoorReliefReturnSection.MixedAirWithDamper
secOutRel(...
final typCtlEco=ctl.typCtlEco,
This is not a regression: we can verify that with older commits of ctrl-flow (e.g. 99776d3) the problem already existed.
There is currently a patch in MBL master for such basic constructs where a parameter is declared in a base class and assigned a final value when instantiating the derived class.
For instance, in Buildings.Templates.AirHandlersFans.Components.Interfaces.PartialOutdoorReliefReturnSection we have:
parameter Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer typCtlEco=
Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer.FixedDryBulb
"Economizer control type"annotation (__ctrlFlow(enable=false),
This explains the difference in the UI between the MBL master and commit b3f5c3ffd7.
TODO:
Implement the logic to detect final modifiers using ctrl-flow, in accordance with MSL rules.
Once this issue is resolved, refactor MBL templates to eliminate all __ctrlFlow(enable=false) annotations that are no longer required.
The text was updated successfully, but these errors were encountered:
With
the
final
keyword is disregarded for the parametersecOutRel.typCtlEco
.This parameter should not appear in the configuration panel due to the following binding in
Buildings.Templates.AirHandlersFans.VAVMultiZone
.This is not a regression: we can verify that with older commits of ctrl-flow (e.g. 99776d3) the problem already existed.
There is currently a patch in MBL master for such basic constructs where a parameter is declared in a base class and assigned a final value when instantiating the derived class.
For instance, in
Buildings.Templates.AirHandlersFans.Components.Interfaces.PartialOutdoorReliefReturnSection
we have:This explains the difference in the UI between the MBL master and commit b3f5c3ffd7.
TODO:
__ctrlFlow(enable=false)
annotations that are no longer required.The text was updated successfully, but these errors were encountered: