Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SpeedCntrolled_Nrpm models in Obsolete package #3968

Closed
mwetter opened this issue Aug 27, 2024 · 0 comments · Fixed by #3975
Closed

Remove SpeedCntrolled_Nrpm models in Obsolete package #3968

mwetter opened this issue Aug 27, 2024 · 0 comments · Fixed by #3975
Assignees

Comments

@mwetter
Copy link
Member

mwetter commented Aug 27, 2024

With the introduction of #3965, the examples for Obsolete*SpeedCntrolled_Nrpm no longer work (as the replaceable is not valid). This model and the similar one that is preconfigured, was retired in May 2023 and can be removed now.

There are also various examples that use Obsolete*SpeedCntrolled_Nrpm which can also be removed, together with the .mos files and reference results.

@hcasperfu : Can you please make this change and also update the release notes. The same should also be done in IBPSA as the changes from #3965 will be discussed for introduction to IBPSA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants