Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Odysee] Autoplay functional while disabled #7090

Closed
Tcll opened this issue Sep 14, 2021 · 10 comments · Fixed by #7173
Closed

[Odysee] Autoplay functional while disabled #7090

Tcll opened this issue Sep 14, 2021 · 10 comments · Fixed by #7173
Labels
type: bug Existing functionality is wrong or broken

Comments

@Tcll
Copy link

Tcll commented Sep 14, 2021

first off, I'm not certain where to direct odysee.com issues to, but I'm aware the team works on it...

but as you can see here:
Screenshot_2021-09-14_09-45-27
at the bottom right, you can see the autoplay switch is off
but I also have autoplay disabled in account settings

there's no reason autoplay should be functional.

only reason I'm bringing it up now, is because the switch would be on when I started my browser
but turning it off wouldn't autoplay until I re-opened the browser
... however now the settings seem to be completely ignored, and it's extremely annoying.

@Tcll Tcll added the type: bug Existing functionality is wrong or broken label Sep 14, 2021
@tzarebczan
Copy link
Contributor

Thanks for filing, this is the right repo. Maybe some strange state mismatch - seems to work here as expected. Do you get a notification in the bottom right when you turn on off autoplay? If not, press ctrl-shift-R to make sure you're on the latest version of the site. Then try to toggle it on and off again to see if that helps.

@saltrafael anything obvious in the code?

@Tcll
Copy link
Author

Tcll commented Sep 14, 2021

hmm, I've just done a refresh in case un-hibernating the tab and clicking on "Following" doesn't change things.
but I'm currently done watching for the day, so we'll see if that fixes things tomorrow ;)

Do you get a notification in the bottom right when you turn on off autoplay?

I did not... the switch seems to be aesthetic only...
but I've refreshed, so we'll see how things go tomorrow 👍

@tzarebczan
Copy link
Contributor

Try a refresh with ctrl-shift-R to make sure the latest version is pulled in. When you toggle/untoggle, it should show you a little message (similar to following/unfollowing someone)

@Tcll
Copy link
Author

Tcll commented Sep 15, 2021

well, I did a refresh, but it didn't change much other than getting the message to appear
turns out the switch is just inverted

or if not that, then the default state of the switch is ignored and overridden by the initial page load defaulting to autoplay enabled
where toggling the switch in whatever state it's initially in disables it
(the switch is on currently, but autoplay is disabled, we'll see if my theory is correct tomorrow if turning it off disables it when I open my browser)

@tzarebczan
Copy link
Contributor

Which browser are you using? Haven't heard any other complaints about this, which we did when we weren't saving the setting properly, etc cause it would piss people off :)

@Tcll
Copy link
Author

Tcll commented Sep 16, 2021

yep my extended theory was exactly correct, the switch is ignored when the page is first loaded on browser startup with the setting defaulting to "on" ;)
the switch wasn't inverted today, but should be inverted tomorrow if my theory still stands and isn't fixed by then.

Which browser are you using?

I currently use Vivaldi, but will be switching to Librewolf when I finally delete this old Linux distro (which is actually progressing), so hopefully there's no issues there. >.>
(Librewolf doesn't run on GLIBC 2.23, so I can't currently use it)

don't forget I also block malware, so that could potentially be another issue if you guys use any for maintaining that setting. :)
(such as how I can't upload images or edit posts anymore here because the menu and upload functionality now uses malware to function)
^ you should be self-hosting a GiTea instance so you don't have to deal with Microsoft malware ;)

@Tcll
Copy link
Author

Tcll commented Sep 17, 2021

just want to update it seems to be working fine today :)
the state of the switch was correctly maintained and autoplay functioned as expected

I'll continue testing just to make sure things are final throughout the week...
if I don't respond with any related errors, if anything at all, this issue can be closed. ;)

here's a preemptive thanks unless I do find something funky 👍

@tzarebczan
Copy link
Contributor

Thanks for the update - really not sure what that may have been. Please re-open if it happens again.

@keikari
Copy link
Contributor

keikari commented Sep 26, 2021

I noticed the behavior for me on Odysee. I guess the toggle is showing wrong info?
Shows it's off, but the setting seems to be showing it's on.
auto-play-bug

@tzarebczan
Copy link
Contributor

@saltrafael can you look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Existing functionality is wrong or broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants