We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@pure
After upgrading to v5, I spent some time figuring out why the code broke, but this wasn't detected by PHPStan or any other tool.
After some tests, I found out that the reason is making the Builder immutable (#979) in the version.
Please consider marking the methods @pure, so SCA can report that 'the result is not used'.
Rule check example: https://phpstan.org/r/f638ba16-0ab3-44e2-becd-2927e99ada09
The text was updated successfully, but these errors were encountered:
Thank you for your rightful complaint: could you please send a PR to fix this?
Sorry, something went wrong.
@Slamdunk done: #1076
Successfully merging a pull request may close this issue.
After upgrading to v5, I spent some time figuring out why the code broke, but this wasn't detected by PHPStan or any other tool.
After some tests, I found out that the reason is making the Builder immutable (#979) in the version.
Please consider marking the methods
@pure
, so SCA can report that 'the result is not used'.Rule check example: https://phpstan.org/r/f638ba16-0ab3-44e2-becd-2927e99ada09
The text was updated successfully, but these errors were encountered: