Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The easiest is not always the safest... #21

Closed
3 tasks done
lcobucci opened this issue Apr 1, 2015 · 0 comments
Closed
3 tasks done

The easiest is not always the safest... #21

lcobucci opened this issue Apr 1, 2015 · 0 comments
Assignees
Milestone

Comments

@lcobucci
Copy link
Owner

lcobucci commented Apr 1, 2015

To make things easier to the end user of the library I've followed some aspects from another libs, and the Token::verify() was one of them, but after reading this article I think we should change some things (for good).

  • Remove Signer from Signature (and change the BaseSigner);
  • Remove Signer\Factory (and change the Parser);
  • Pass signer on Token::verify() (to validate if the alg header matches) and the Signature::verify() (to see if the signature was created by that signer with the expected key);

Those changes are easy to do and will simplify things (yes Parser I'm talking to you), but since is a BC break I'm moving it to next major release (3.0.0).

Do you guys have any consideration about this?

@lcobucci lcobucci added this to the 3.0.0 milestone Apr 1, 2015
@lcobucci lcobucci mentioned this issue Apr 1, 2015
4 tasks
@lcobucci lcobucci self-assigned this Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant