Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoder is turning objects into arrays #23

Closed
lcobucci opened this issue Apr 1, 2015 · 0 comments
Closed

Decoder is turning objects into arrays #23

lcobucci opened this issue Apr 1, 2015 · 0 comments
Assignees
@lcobucci
Labels
BC-break Improvement
Milestone
3.0.0

Comments

@lcobucci
Copy link
Owner

lcobucci commented Apr 1, 2015

The lib is converting objects into arrays instead of instances of stdClass (by calling json_decode($json, true)).

This will cause some troubles when we're validating a token that have an empty object inside a claim. I think we should remove that true parameter and receive the stdClass to prevent this thing.

Is anyone against this?
@lcobucci lcobucci added this to the 3.0.0 milestone Apr 1, 2015
@lcobucci lcobucci self-assigned this Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcobucci lcobucci

Labels
BC-break Improvement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@lcobucci