Skip to content
This repository was archived by the owner on Dec 20, 2019. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ldc-developers/compiler-rt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a4cbb02bca3b952117e9ccfbad8a485857f25935
Choose a base ref
...
head repository: ldc-developers/compiler-rt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: eecfd6d449402aaf379cc5b30d18264e8333c769
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 27, 2018

  1. Misc. fixes for builtins lib on Windows 

    * Include ASM files when using MSVC-compatible clang-cl.exe as C
  compiler (and its assembler supporting AT&T syntax).
* Disable buffer overflow checks to prevent dependencies on special MS C
  symbols. => /GS-
* Use `/Zl` to prevent dragging in libcmt.lib.
    @kinke
    kinke committed Oct 27, 2018

    Verified

    This commit was signed with the committer’s verified signature.
    erlend-aasland Erlend E. Aasland
    GPG key ID: B43BA0441310AE16
    Verified
    Learn about vigilant mode
    Copy the full SHA
    eecfd6d View commit details
Showing with 8 additions and 3 deletions.
  1. +8 −3 lib/builtins/CMakeLists.txt
11 changes: 8 additions & 3 deletions lib/builtins/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
@@ -230,7 +230,7 @@ set(x86_ARCH_SOURCES
powixf2.c
)

if (NOT MSVC)
if (NOT CMAKE_ASM_COMPILER_ID MATCHES "MSVC")
set(x86_64_SOURCES
x86_64/floatdidf.c
x86_64/floatdisf.c
@@ -271,7 +271,7 @@ if (NOT MSVC)
i386/chkstk.S
i386/chkstk2.S)
endif()
else () # MSVC
else () # MSVC assembler
# Use C versions of functions when building on MSVC
# MSVC's assembler takes Intel syntax, not AT&T syntax.
# Also use only MSVC compilable builtin implementations.
@@ -282,12 +282,17 @@ else () # MSVC
${GENERIC_SOURCES})
set(x86_64h_SOURCES ${x86_64_SOURCES})
set(i386_SOURCES ${GENERIC_SOURCES})
endif () # if (NOT MSVC)
endif ()

set(x86_64h_SOURCES ${x86_64h_SOURCES} ${x86_ARCH_SOURCES})
set(x86_64_SOURCES ${x86_64_SOURCES} ${x86_ARCH_SOURCES})
set(i386_SOURCES ${i386_SOURCES} ${x86_ARCH_SOURCES})
set(i686_SOURCES ${i686_SOURCES} ${x86_ARCH_SOURCES})
if (MSVC)
set_source_files_properties(
${x86_64h_SOURCES} ${x86_64_SOURCES} ${i386_SOURCES} ${i686_SOURCES}
PROPERTIES COMPILE_FLAGS "/GS- /Zl")
endif()

set(arm_SOURCES
arm/bswapdi2.S