Implement new Target::supportsLinkerDirective() properly

Author: kinke

dmd/target.d

@@ -811,8 +811,7 @@ version (IN_LLVM)
     Expression getTargetInfo(const(char)* name, const ref Loc loc);
     bool isCalleeDestroyingArgs(TypeFunction tf);
     bool libraryObjectMonitors(FuncDeclaration fd, Statement fbody) { return true; }
-    bool supportsLinkerDirective() const { return true; }
-
+    bool supportsLinkerDirective() const;
 }
 else // !IN_LLVM
 {

gen/declarations.cpp

@@ -17,6 +17,7 @@
 #include "dmd/init.h"
 #include "dmd/nspace.h"
 #include "dmd/root/rmem.h"
+#include "dmd/target.h"
 #include "dmd/template.h"
 #include "driver/cl_options.h"
 #include "gen/classes.h"
@@ -440,7 +441,7 @@ class CodegenVisitor : public Visitor {
       }
     } else if (decl->ident == Id::linkerDirective) {
       // embed in object file (if supported)
-      if (triple.isWindowsMSVCEnvironment() || triple.isOSBinFormatMachO()) {
+      if (target.supportsLinkerDirective()) {
         assert(decl->args);
         llvm::SmallVector<llvm::StringRef, 2> args;
         args.reserve(decl->args->length);

gen/target.cpp

@@ -325,3 +325,8 @@ bool Target::isCalleeDestroyingArgs(TypeFunction* tf) {
   return global.params.targetTriple->isWindowsMSVCEnvironment() ||
          tf->linkage != LINK::cpp;
 }
+
+bool Target::supportsLinkerDirective() const {
+  return global.params.targetTriple->isWindowsMSVCEnvironment() ||
+         global.params.targetTriple->isOSBinFormatMachO();
+}

tests/codegen/linker_directives_linux.d

@@ -1,11 +1,11 @@
-// RUN: %ldc -mtriple=x86_64-linux-gnu -output-ll -of=%t.ll %s && FileCheck %s < %t.ll
+// RUN: not %ldc -mtriple=x86_64-linux-gnu -o- %s
+// RUN: %ldc -mtriple=x86_64-linux-gnu -ignore -output-ll -of=%t.ll %s && FileCheck %s < %t.ll
 
 // REQUIRES: target_X86
 
 // CHECK: !llvm.dependent-libraries = !{!0}
 // CHECK: !0 = !{!"mylib"}
 pragma(lib, "mylib");
 
-// silently ignored because not (yet?) embeddable in ELF object file:
+// not (yet?) embeddable in ELF object file
 pragma(linkerDirective, "-myflag");
-pragma(linkerDirective, "-framework", "CoreFoundation");