Skip to content

Commit 43643d4

Browse files
committed
[LDC] PGO: Avoid COMDAT members with private linkage for Windows
To prevent according IR verifier errors with IR-based PGO ('comdat global value has private linkage').
1 parent e86602a commit 43643d4

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

llvm/lib/ProfileData/InstrProf.cpp

+7-2
Original file line numberDiff line numberDiff line change
@@ -448,8 +448,13 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
448448
else if (Linkage == GlobalValue::AvailableExternallyLinkage)
449449
Linkage = GlobalValue::LinkOnceODRLinkage;
450450
else if (Linkage == GlobalValue::InternalLinkage ||
451-
Linkage == GlobalValue::ExternalLinkage)
452-
Linkage = GlobalValue::PrivateLinkage;
451+
Linkage == GlobalValue::ExternalLinkage) {
452+
// LDC: use internal instead of private linkage for COFF (still local, but
453+
// allows for COMDATs on Windows)
454+
Linkage = Triple(M.getTargetTriple()).isOSBinFormatCOFF()
455+
? GlobalValue::InternalLinkage
456+
: GlobalValue::PrivateLinkage;
457+
}
453458

454459
auto *Value =
455460
ConstantDataArray::getString(M.getContext(), PGOFuncName, false);

0 commit comments

Comments
 (0)