We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent e86602a commit 43643d4Copy full SHA for 43643d4
llvm/lib/ProfileData/InstrProf.cpp
@@ -448,8 +448,13 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
448
else if (Linkage == GlobalValue::AvailableExternallyLinkage)
449
Linkage = GlobalValue::LinkOnceODRLinkage;
450
else if (Linkage == GlobalValue::InternalLinkage ||
451
- Linkage == GlobalValue::ExternalLinkage)
452
- Linkage = GlobalValue::PrivateLinkage;
+ Linkage == GlobalValue::ExternalLinkage) {
+ // LDC: use internal instead of private linkage for COFF (still local, but
453
+ // allows for COMDATs on Windows)
454
+ Linkage = Triple(M.getTargetTriple()).isOSBinFormatCOFF()
455
+ ? GlobalValue::InternalLinkage
456
+ : GlobalValue::PrivateLinkage;
457
+ }
458
459
auto *Value =
460
ConstantDataArray::getString(M.getContext(), PGOFuncName, false);
0 commit comments