Skip to content

Commit cf54259

Browse files
committed
[LDC] PGO: Avoid COMDAT members with private linkage for Windows
To prevent according IR verifier errors with IR-based PGO ('comdat global value has private linkage').
1 parent 1d1b2e9 commit cf54259

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

llvm/lib/ProfileData/InstrProf.cpp

+7-2
Original file line numberDiff line numberDiff line change
@@ -360,8 +360,13 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
360360
else if (Linkage == GlobalValue::AvailableExternallyLinkage)
361361
Linkage = GlobalValue::LinkOnceODRLinkage;
362362
else if (Linkage == GlobalValue::InternalLinkage ||
363-
Linkage == GlobalValue::ExternalLinkage)
364-
Linkage = GlobalValue::PrivateLinkage;
363+
Linkage == GlobalValue::ExternalLinkage) {
364+
// LDC: use internal instead of private linkage for COFF (still local, but
365+
// allows for COMDATs on Windows)
366+
Linkage = Triple(M.getTargetTriple()).isOSBinFormatCOFF()
367+
? GlobalValue::InternalLinkage
368+
: GlobalValue::PrivateLinkage;
369+
}
365370

366371
auto *Value =
367372
ConstantDataArray::getString(M.getContext(), PGOFuncName, false);

0 commit comments

Comments
 (0)