Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover info doesn't increment past the shortest dataset's max X value #158

Open
badair opened this issue Nov 12, 2016 · 2 comments
Open

Hover info doesn't increment past the shortest dataset's max X value #158

badair opened this issue Nov 12, 2016 · 2 comments

Comments

@badair
Copy link

badair commented Nov 12, 2016

chart_point

The hover info in this screenshot shows 280, even though the point is at the 300 vertical. This might be a bug in a different project, I don't know. Either way, it's really minor. live example

Edit: love the tool, by the way.

@ldionne
Copy link
Owner

ldionne commented Nov 14, 2016

I'm not sure whether it's actually a bug. The thing is that you're really looking at two different points, one on the blue curve and the other one on the orange curve. These two points have a different X value, but the tooltip is only showing one X value. Which one should it show? Should it stop showing the blue point when you're out of range? Also note that the Y value of the orange curve is updating properly, i.e. it does not stay stuck at the X=280.

@badair
Copy link
Author

badair commented Dec 23, 2016

Which one should it show? Should it stop showing the blue point when you're out of range?

Yes, I would think so. I think ideally the X axis value would update to the hovered point (e.g. 300 would show in the screenshot above, since that's where my cursor is), and the datasets that do not cross the vertical would disappear from the tooltip. I guess I wouldn't spend my free time changing it (it's already far more polished than I would expect), but I wanted to bring it to your attention in case it's something you'd want to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants