fix invalid GeoJSON produced by nested LayerGroups #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanSanchez
approved these changes
Feb 27, 2017
There was a problem hiding this comment.
After reading https://gis.stackexchange.com/questions/176801/how-to-include-a-geojson-featurecollection-inside-another-featurecollection , I'm inclined to accept this. I wonder if any other core devs @perliedman @mourner have any opinions on this.
IvanSanchez
reviewed
Feb 27, 2017
| @@ -356,4 +356,17 @@ describe("L.LayerGroup#toGeoJSON", function () { | |||
| features: [] | |||
| }); | |||
| }); | |||
|
|
|||
| it('should return only one FeatureCollection for nested LayerGroups', function () { | |||
mourner
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a LayerGroup contains another LayerGroup .toGeoJSON returns an invalid GeoJSON object as it will return nested FeatureCollection objects.
This fix squashes nested FeatureCollections by concatenating their features array with the parent FeatureCollection's features array.
The GeoJSON spec states that a FeatureCollection's features property contains an array of Feature objects.
http://geojson.org/geojson-spec.html#feature-collection-objects
Currently LayerGroup.toGeoJSON will return a FeatureCollection where the features array may contain one or more FeatureCollection objects.
Example:
https://playground-leaflet.rhcloud.com/pin/2/edit?html,console