Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Analysis/Normed/Ring/WithAbs): make equiv a ring equiv #20713

Closed
wants to merge 4 commits into from

Conversation

MichaelStollBayreuth
Copy link
Collaborator

Making WithAbs.equiv a ring equivalence (like WithAbs.ringEquiv) should make a lot of the API lemmas obsolete.


Open in Gitpod

@MichaelStollBayreuth MichaelStollBayreuth added WIP Work in progress awaiting-CI t-analysis Analysis (normed *, calculus) labels Jan 13, 2025
Copy link

github-actions bot commented Jan 13, 2025

PR summary 1127cf4e99

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 14, 2025
Making `WithAbs.equiv` a ring equivalence (like `WithAbs.ringEquiv`) should make a lot of the API lemmas obsolete.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/Normed/Ring/WithAbs): make equiv a ring equiv [Merged by Bors] - chore(Analysis/Normed/Ring/WithAbs): make equiv a ring equiv Jan 14, 2025
@mathlib-bors mathlib-bors bot closed this Jan 14, 2025
@mathlib-bors mathlib-bors bot deleted the MS_WithAbs_variant branch January 14, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants