Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

feat(leanpkg): add git branch tracking for dependencies #1981

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

khoek
Copy link
Contributor

@khoek khoek commented Nov 12, 2018

Add branch tracking for git dependencies. There is no functional change to currently existing leanpkg.toml manifests. In a git dependency an optional branch="..." (along with the required git=... and rev=...) is now permitted, which will cause subsequent invocations of leanpkg upgrade to track that branch, as opposed to a default determined by the Lean version.

We opt to store the branch name inside an option string, instead of just picking a default the first time leanpkg.toml is read with it missing, since then when leanpkg.toml is re-written unexpected branch = "..." entries will not appear (as was the case with the old behaviour).

@Kha
Copy link
Member

Kha commented Nov 12, 2018

Looks great, thanks!

@Kha Kha merged commit 1229f9b into leanprover:master Nov 12, 2018
@khoek khoek deleted the git-deps-tracking branch December 20, 2018 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants