This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
feat(leanpkg): add git branch tracking for dependencies #1981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add branch tracking for git dependencies. There is no functional change to currently existing
leanpkg.toml
manifests. In a git dependency an optionalbranch="..."
(along with the requiredgit=...
andrev=...
) is now permitted, which will cause subsequent invocations ofleanpkg upgrade
to track that branch, as opposed to a default determined by the Lean version.We opt to store the branch name inside an
option string
, instead of just picking a default the first timeleanpkg.toml
is read with it missing, since then whenleanpkg.toml
is re-written unexpectedbranch = "..."
entries will not appear (as was the case with the old behaviour).