Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Core) : a₁ and a₂ instead of a1 and a2 #6764

Closed
wants to merge 1 commit into from

Conversation

madvorak
Copy link
Contributor

@madvorak madvorak commented Jan 24, 2025

style: Core/Init/Subtype.eq
Name arguments idiomatically a₁ and a₂ instead of a1 and a2

@nomeata
Copy link
Collaborator

nomeata commented Jan 24, 2025

Thanks for trying to make lean better. However, I don't think a change like this has enough impact to justify the work that goes into it (reading, reviewing, merging, wondering about whether this is a breaking change for users who explicitly specify arguments), so I'll take the liberty to reject this one.

Maybe in the future we'll have and enforce a style guide, and fix issues like these at efficiently scale.

@nomeata nomeata closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants