Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor climsim_utils.data_utils into preprocessing and evaluation #17

Open
cisaacstern opened this issue Aug 17, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@cisaacstern
Copy link
Contributor

Per @jerrylin96's explanation, data_utils currently performs two functions:

  • preprocessing
  • evaluation

which are largely separable. For maintainability/readability it probably makes sense to refactor these into separate python modules, so the imports would then look like:

from climsim_utils.preprocessing import something
from climsim_utils.evaluation import something_else
@cisaacstern
Copy link
Contributor Author

Noting #24 should be addressed first to establish a benchmark of current functionality before refactoring.

@cisaacstern cisaacstern added the enhancement New feature or request label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant