Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

challengeExit() needs to check that the periods the proofs reference were actually submitted to the bridge. #260

Closed
TheReturnOfJan opened this issue Dec 5, 2019 · 17 comments · Fixed by #270
Closed

challengeExit() needs to check that the periods the proofs reference were actually submitted to the bridge. #260

TheReturnOfJan opened this issue Dec 5, 2019 · 17 comments · Fixed by #270
Labels
bounty bug Something isn't working security size-XS total effort of ~200 DAI Status: Available

Comments

@TheReturnOfJan
Copy link

TheReturnOfJan commented Dec 5, 2019 •
edited by simonweniger
Loading

Bounty

the challengeExit() function of the ExitHandler contract doesn't check proofs for inclusion in the Bridge contract.

Scope

  • add check
  • add test to prevent regression

Deliverables

  • code
  • tests

Gain for the project

  • more secure challenges
@troggy
Copy link
Member

troggy commented Dec 5, 2019 •
edited
Loading

@TheReturnOfJan such a title for an issue is not helpful when you scan through issues list, because this function is undefined in that context 😆

image

@johannbarbie johannbarbie added bug Something isn't working security bounty labels Dec 16, 2019
@johannbarbie johannbarbie changed the title This function needs to check that the periods the proofs reference were actually submitted to the bridge. challengeExit() needs to check that the periods the proofs reference were actually submitted to the bridge. Dec 16, 2019
@johannbarbie johannbarbie added the size-XS total effort of ~200 DAI label Jan 2, 2020
@johannbarbie
Copy link
Member

original issue content by @TheReturnOfJan :

leap-contracts/contracts/ExitHandler.sol

Line 320 in 74d2dc4

function challengeExit(

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 145.0 DAI (145.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Jan 3, 2020 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 7 hours from now.
Please review their action plans below:

1) pumpkingwok has been approved to start work.

Hi there, i could start to work in it from tomorrow if it is still free. Thanks in advance
2) sanchaymittal has applied to start work (Funders only: approve worker | reject worker).

I will work as per the requirements.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@PumpkingWok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@simonweniger
Copy link
Member

Hey @PumpkingWok , thanks for starting to work on the bounty. LeapDAO is a Decentralized Autonomous Organisation creating the Leap Network, a scalable second layer solution for the Ethereum Blockchain. The holacratic DAO has over 20 active members world-wide developing and maintaining the network. Its mission is to enable scalable Dapps to operate securely on layer-2 of Ethereum as well as widening the scope of possible Dapps in the Ethereum ecosystem.

If you're intrested to join LeapDAO and contribute to the project long term feel free to join our slack and check all available bountys

greetings Simon Weniger
DEV Link at LeapDAO

@PumpkingWok
Copy link
Contributor

Hi @simonweniger,
Thanks for the infos that you gave to me. In the last week i have read the whitepaper, really interesting.
I had already heard about this project via Gitcoin and Grants during the last year.
I'm going to add the check in challengeExit() and test during this week. Also i will join the slack channel for sure, maybe i could ask some questions.
Thanks a lot in advance, have a nice day !!

@gitcoinbot
Copy link

@PumpkingWok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@PumpkingWok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@PumpkingWok due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@PumpkingWok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@PumpkingWok
Copy link
Contributor

Hi there,
Yes i have already created a WIP PR.
Thanks

@gitcoinbot
Copy link

@PumpkingWok Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@PumpkingWok due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@PumpkingWok
Copy link
Contributor

Hi there,
I have already created a PR. thanks.

@PumpkingWok PumpkingWok mentioned this issue Jan 27, 2020
Merged
2 tasks
@PumpkingWok PumpkingWok mentioned this issue Feb 3, 2020
Open
@gitcoinbot
Copy link

⚡️ A tip worth 145.00000 DAI (145.0 USD @ $1.0/DAI) has been granted to @PumpkingWok for this issue from @simonweniger. ⚡️

Nice work @PumpkingWok! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Additional Tips for this Bounty:

  • simonweniger tipped 145.0000 DAI worth 145.0 USD to pumpkingwok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty bug Something isn't working security size-XS total effort of ~200 DAI Status: Available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add periods check on proof in challengeExit() PumpkingWok/leap-contracts
6 participants
@troggy @johannbarbie @PumpkingWok @gitcoinbot @simonweniger @TheReturnOfJan