Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support "yarn global add leap-node" with node -v >= 12 #346

Closed
johannbarbie opened this issue Nov 1, 2019 · 11 comments · Fixed by #396
Closed

support "yarn global add leap-node" with node -v >= 12 #346

johannbarbie opened this issue Nov 1, 2019 · 11 comments · Fixed by #396

Comments

@johannbarbie
Copy link
Member

johannbarbie commented Nov 1, 2019

Bounty Description:

when running yarn global add leap-node the expected out is successful install. With node versions >= 12. the following output is observed:

...
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/johba/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:210:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 18.7.0
gyp ERR! command "/Users/johba/.nvm/versions/node/v12.13.0/bin/node" "/Users/johba/.nvm/versions/node/v12.13.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/johba/.config/yarn/global/node_modules/scrypt

Scope

  • fix code or dependencies so that install with node -v > 12 passes successfully on linux and OSX

Gain for the project

  • support broader stack and reduce frustration during installation
@johannbarbie
Copy link
Member Author

works with node 11

@troggy troggy changed the title ReferenceError: primordials is not defined Add support for nodejs 12.* Nov 1, 2019
@sunify sunify self-assigned this Nov 11, 2019
@troggy
Copy link
Member

troggy commented Jan 2, 2020

Unassigning @sunify — no progress

@johannbarbie johannbarbie changed the title Add support for nodejs 12.* support "yarn global add" with node -v >= 12 Jan 2, 2020
@johannbarbie johannbarbie changed the title support "yarn global add" with node -v >= 12 support "yarn global add leap-node" with node -v >= 12 Jan 2, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 227.0 DAI (227.0 USD @ $1.0/DAI) attached to it as part of the https://github.com/leapdao fund.

@gitcoinbot
Copy link

gitcoinbot commented Jan 3, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 week from now.
Please review their action plans below:

1) agbilotia1998 has been approved to start work.

1.) Look at the error trace.
2.) Update dependencies accordingly.

Learn more on the Gitcoin Issue Details page.

@simonweniger
Copy link
Member

Hey @agbilotia1998 , thanks for starting to work on the bounty. LeapDAO is a Decentralized Autonomous Organisation creating the Leap Network, a scalable second layer solution for the Ethereum Blockchain. The holacratic DAO has over 20 active members world-wide developing and maintaining the network. Its mission is to enable scalable Dapps to operate securely on layer-2 of Ethereum as well as widening the scope of possible Dapps in the Ethereum ecosystem.

If you're intrested to join LeapDAO and contribute to the project long term feel free to join our slack and check all available bountys

greetings Simon Weniger
DEV Link at LeapDAO

@agbilotia1998
Copy link
Contributor

Hi @simonweniger sorry for the delay in response and thanks for your approval on the issue, I'll come up with the solution ASAP. Sure, I'll look at the slack channel as well.

@eshavkun
Copy link
Contributor

eshavkun commented Jan 9, 2020

@agbilotia1998 Just fyi, I found that issue is with scrypt package. It was last updated 4 years ago and according to their github (https://github.com/barrysteyn/node-scrypt) is depricated.
Also it appears that there is a dependency on the old version of web3 ("web3": "1.0.0-beta.37") which also doesn't support nodejs v12. Probably some other packages have such dependency as well.

@gitcoinbot
Copy link

@agbilotia1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@agbilotia1998
Copy link
Contributor

@eshavkun the later versions of web3 fix the scrypt package issue with this PR web3/web3.js#2938
But on upgrading to the latest version of web3, the error still persists.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 227.0 DAI (227.0 USD @ $1.0/DAI) has been submitted by:

  1. @agbilotia1998

@simonweniger please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 227.0 DAI (227.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @agbilotia1998.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants