Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With go >= 1.13 package integration checks stop dependency installation #8

Open
TimDaub opened this issue Oct 1, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@TimDaub
Copy link

TimDaub commented Oct 1, 2019

Bounty

Scope

In go 1.13, some advanced integrity integration for dependencies is added. For details, see: https://golang.org/doc/go1.13 "Version validation"

--> Installing golangci/golangci-lint (7b2421d55194c9dc385eff7720a037aa9244ca3c)...
Cloning into 'golangci/golangci-lint'...
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 10873 (delta 2), reused 0 (delta 0), pack-reused 10863
Receiving objects: 100% (10873/10873), 10.00 MiB | 1.66 MiB/s, done.
Resolving deltas: 100% (5398/5398), done.
~/go/src/github.com/golangci/golangci-lint ~/go/src/github.com
go: github.com/go-critic/go-critic@v0.0.0-20181204210945-0af0999fabfb: invalid pseudo-version: does not match version-control timestamp (2019-01-08T19:27:14Z
)
make: *** [get_tools] Error 1
  • It's likely that this problem has been addressed upstream already. I haven't searched for a specific PR or issue.

Deliverables

  • Allow tendermint to be used with go >= 1.13 by e.g. specifying the packages that are failing to install correctly or by e.g. simply taking a fix from upstream

Gain for the project

  • Using the latest version of go to run Tendermint

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 25%

@TimDaub TimDaub added the bug Something isn't working label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant