Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance to useKLiveRegion doc page regarding the actionable element focus #716

Open
MisRob opened this issue Aug 7, 2024 · 10 comments
Assignees
Labels
help wanted Open source contributors welcome

Comments

@MisRob
Copy link
Member

MisRob commented Aug 7, 2024

Follow-up to @radinamatic's feedback in learningequality/kolibri#12475:

Screenshot from 2024-08-07 17-36-08

@MisRob MisRob self-assigned this Aug 7, 2024
@MisRob MisRob removed their assignment Jan 22, 2025
@MisRob MisRob added the help wanted Open source contributors welcome label Jan 22, 2025
@Mamatha1718
Copy link

Hi @MisRob , I would like to tackle this issue, will you please assign it to me and guide me where would i start to develop this documentation.
Thank you.

@MisRob
Copy link
Member Author

MisRob commented Jan 23, 2025

Hi @Mamatha1718, thank you, I will assign you. Here's the guidance I usually post for documentation writing:

Guidance

@MisRob
Copy link
Member Author

MisRob commented Jan 23, 2025

@Mamatha1718 After you have run the development server (see the contributing guidelines) and familiarized yourself with the guidance above, you're welcome to post here if there are further questions

@AlexVelezLl
Copy link
Member

Hi @Mamatha1718! Were you able to setup your dev server? If you have any question, please let us know :).

@Mamatha1718
Copy link

Hi @AlexVelezLl , I am facing an issues in running the command yarn run devserver
i attach a screenshot for reference

Image

Image

Thank You

@adibmbrk
Copy link
Contributor

Hey @Mamatha1718! We don't usually recommend using Windows for development as it's not stable at the moment with this repo, maybe you could try using WSL. You can use the following guide learningequality/studio#4904 , It's written for studio, but you can get an idea on how to do it .

@AlexVelezLl
Copy link
Member

Hey @Mamatha1718, you can open a github dicussion to help you better to solve the error you are seeing, however, you dont need to run Kolibri for tackling this issue. We just need KDS here, and we need to follow the instructions that @MisRob sent earlier :).

@Mamatha1718
Copy link

Hi @adibmbrk @AlexVelezLl , Thanks for your clarification.

@Mamatha1718
Copy link

Mamatha1718 commented Feb 14, 2025

Hi @MisRob , @AlexVelezLl , @adibmbrk ,
I have made changes to the KTextbox and KImg source code to improve clarity by separating text and number input functionality. Will you please let me know any changes need, However, I couldn't find the existing documentation files for these components.

Could you please provide me with the correct documentation files so I can make the necessary updates? If the documentation doesn't exist, would it be okay for me to create new documentation files for these components?

Looking forward to your response.

Thank you!

@MisRob
Copy link
Member Author

MisRob commented Feb 17, 2025

Hello @Mamatha1718, I replied in your pull request. Regarding finding code to update, you could either study the development documentation or run the development server, navigate to /usekliveregion page, and finally use Vue DevTools that have features to help you find code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open source contributors welcome
Projects
None yet
Development

No branches or pull requests

4 participants