Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement individual conditional loading behaviour in every page that uses the CoachImmersivePage #11422

Open
rtibbles opened this issue Oct 17, 2023 · 4 comments
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend P2 - normal Priority: Nice to have

Comments

@rtibbles
Copy link
Member

rtibbles commented Oct 17, 2023

Blocked by

#11219

Observed behavior

Every page that uses the CoachImmersivePage was built with the assumption that its components would not be rendered until all relevant data had been loaded.

To prevent this causing issues due to loading of data into state, a global loading guard was added to the CoachImmersivePage in #11392 to ensure that errors did not happen due to the component being instantiated before its data was ready.

Expected behavior

Each individual page should handle its own loading state, according to the guidelines laid out here: https://design-system.learningequality.org/loaders/ and the global loading guard should be removed.

This could be initially addressed by moving the global guard into each individual page component, conditionalized on the core loading state. Follow up work could then happen to allow each individual page to better handle its data loading, in a pattern similar to https://github.com/learningequality/kolibri/blob/release-v0.16.x/kolibri/plugins/learn/assets/src/views/LibraryPage/index.vue where handlers are no longer used for data loading, but all data loading is orchestrated from within the composition API setup method.

@rtibbles rtibbles added P2 - normal Priority: Nice to have APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Oct 17, 2023
@muditchoudhary
Copy link
Contributor

Hello @rtibbles @MisRob I am trying to understand this issue and have a fix for it. Could anyone of you assign it to me? I'll ask if I have a question. Thanks!

@MisRob
Copy link
Member

MisRob commented Dec 14, 2023

Hi @muditchoudhary, thank you for volunteering. This will be possible to resolve after #11219 (work in progress currently) which will prepare ground for this in individual page handlers.

@MisRob
Copy link
Member

MisRob commented Dec 14, 2023

I added the blocked by section to the issue

@muditchoudhary
Copy link
Contributor

Okay. I will wait for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

3 participants