Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF documents in Kolibri are not 100% viewable due to the "go to full screen" bar. #8745

Closed
SerchMX opened this issue Nov 19, 2021 · 3 comments
Closed

PDF documents in Kolibri are not 100% viewable due to the "go to full screen" bar. #8745

SerchMX opened this issue Nov 19, 2021 · 3 comments
Assignees
@marcellamaki
Labels
P1 - important Priority: High impact on UX
Milestone
Planned Patch 2: ...

Comments

@SerchMX
Copy link

SerchMX commented Nov 19, 2021

Observed behavior

If you add any channel that uses PDFs, you will see a banner that allows you to 'enter full screen', at the top of the PDF document. This banner will not hide unless you scroll down the PDF document, so the PDF title will remain behind this banner.

baktun

…

Expected behavior

Would it be possible to hide the banner if you stop moving the mouse pointer or move the pointer outside of the PDF document, or any other method?

User-facing consequences

It was reported by a deployment in Yucatán Mexico, although this behavior is agnostic to specific users.

Steps to reproduce

  1. Open Kolibri
  2. Add any channel that has a PDF doc
  3. You will see an "Enter Full Screen" gray banner at the top of the document, which prevents the PDF to show its title.
    If you scroll down the PDF document, the banner dissapears, but if you go to the very top, it will appear again.

Context

  • Kolibri version: 1.0 from Flathub
  • Operating system: Endless OS 3.9.5
  • Browser: Chromium/Chrome
@rtibbles rtibbles added the P1 - important Priority: High impact on UX label Dec 16, 2021
@rtibbles rtibbles modified the milestones: 0.15.0, 0.15.1 Dec 16, 2021
@marcellamaki marcellamaki modified the milestones: 0.15.1, 0.15.2 Jan 31, 2022
@marcellamaki marcellamaki added the TODO: needs QA re-review For stale issues that need to be revisited label Mar 1, 2022
@marcellamaki marcellamaki modified the milestones: 0.15.2, 0.15.3 Mar 4, 2022
@pcenov
Copy link
Member

pcenov commented Mar 15, 2022

@radinamatic this one is still valid in 0.15.1

@rtibbles
Copy link
Member

I think the best solution for this is to just push the PDF rendering area below the toolbar.

@marcellamaki marcellamaki added P0 - critical Priority: Release blocker or regression and removed P0 - critical Priority: Release blocker or regression labels Apr 28, 2022
@marcellamaki marcellamaki modified the milestones: Planned Patch 2: Content and a11y, Planned Patch 3: TBD Apr 28, 2022
@marcellamaki marcellamaki modified the milestones: Planned Patch 3: TBD, Planned Patch 2: Content and a11y May 5, 2022
@marcellamaki marcellamaki removed the TODO: needs QA re-review For stale issues that need to be revisited label May 5, 2022
@marcellamaki marcellamaki mentioned this issue May 16, 2022
Merged
9 tasks
@rtibbles
Copy link
Member

Fixed in #9439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcellamaki marcellamaki

Labels
P1 - important Priority: High impact on UX
Projects
None yet
Milestone
Planned Patch 2: Content and a11y
Development

No branches or pull requests
4 participants
@rtibbles @SerchMX @marcellamaki @pcenov