Remove all instances of the crossComponentTranslator before the next string freeze

[MisRob]

Observed behavior

After the string freeze for the 0.15 release, we couldn't modify strings and their namespaces anymore. That also means that we couldn't move strings between components. We have the crossComponentTranslator utility which allowed us to access translation strings in a component from another component so that we could temporarily work around this. Before the next string freeze, we should clean up all places where the crossComponentTranslator is used, move strings to components from where they are really used or to common string files, and remove all components that are not used but needed to be left in the codebase because they contain some translations.

Example

Translations strings from the OverallStatus component

kolibri/kolibri/plugins/learn/assets/src/views/AssessmentWrapper/OverallStatus.vue

Lines 16 to 23 in 2f93cb0

	$trs: {
	// eslint-disable-next-line kolibri/vue-no-unused-translations
	goal: {
	message: 'Get {count, number, integer} {count, plural, other {correct}}',
	context:
	'Message that indicates to the learner how many correct answers they need to give in order to master the given topic, and for the exercise to be considered completed.',
	},
	},

should be moved to the LessonMasteryBar component

kolibri/kolibri/plugins/learn/assets/src/views/AssessmentWrapper/LessonMasteryBar.vue

Line 30 in 2f93cb0

export default {

and used directly instead of using the crossComponentTranslator

kolibri/kolibri/plugins/learn/assets/src/views/AssessmentWrapper/LessonMasteryBar.vue

Line 28 in 2f93cb0

const overallStatusStrings = crossComponentTranslator(OverallStatus);

kolibri/kolibri/plugins/learn/assets/src/views/AssessmentWrapper/LessonMasteryBar.vue

Line 8 in 2f93cb0

:text="overallStatusStrings.$tr('goal', { count: requiredCorrectAnswers })"

OverallStatus component should then be removed.

Note that removing a component might not be desired at all places that need to be cleaned up since sometimes we share strings between components that are all used. In such cases, the crossComponentTranslator should still be removed and strings can be duplicated in both components, alternatively, they could be moved to shared string files like for example commonCoreStrings, commonLearnStrings, etc. depending on what location is appropriate.

Search codebase for the crossComponentTranslator term to find more.

[photon0205]

Hi!!, Is this issue still valid?

[MisRob]

Hello @photon0205, yes it is still valid, are you asking because you'd like to work on it?

[photon0205]

Yes, I would like to work on this

[MisRob]

Thank you, we appreciate that. I'll assign you. Feel free to start and let me know if you encountered any issues. Depending on how many instances of crossComponentTranslator are currently in the codebase, you may open one pull request or split work into more pull requests if that'd be easier.

[sahej-hira]

I would like to would on this issue. If its still valid, please assign it to me.

[photon0205]

@shark-lamp I am working on it

[radinamatic]

the crossComponentTranslator should still be removed and strings can be duplicated in both components, alternatively, they could be moved to shared string files like for example commonCoreStrings, commonLearnStrings, etc. depending on what location is appropriate.

I did not review the code, but noting that moving the identical strings used in different components into commonCoreStrings or commonLearnStrings is almost always the preferred solution, as duplicating them just inflates our translation word count and needlessly increases the i18n budget.

[Akila-I]

Hi @MisRob @marcellamaki ,
Is this issue still open? If so, I would love to take and work on it.
I have done working on the issue #9867 and the PR #10130 is about to get merged. So I would be free to work on another issue.

[MisRob]

Thank you, @Akila-I, we appreciate your interest. This particular issue is currently time-sensitive so it's been already been assigned to @marcellamaki, who will start working on it soon. I saw that you've already posted a comment of interest to one another issue, so I'd recommend focusing on that.