Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update defaultState in UserManagement #9528

Closed
marcellamaki opened this issue Jun 22, 2022 · 2 comments
Closed

Update defaultState in UserManagement #9528

marcellamaki opened this issue Jun 22, 2022 · 2 comments
Assignees
@rtibbles

Comments

@marcellamaki
Copy link
Member

Observed behavior

In the UserManagement module, the defaultState only contains facilityUsers: []

In the ClassAssignMembers, this default state caused some problems with the page state not being updated properly. It does not seem to be an issue in UserManagement so far in causing an apparent UI bug, but the default state should be consistent across these two modules.

User-facing consequences

Things might be more brittle than we are expecting; potential problems with pagination or state updates yet to be discovered!

Context

v0.15.x
@marcellamaki marcellamaki added this to the Planned Patch 4: Coach usability improvements milestone Jun 22, 2022
@rtibbles
Copy link
Member

If the state is not reset due to the preparePage action the same brittleness arises. Setting some default state fixes the issue also.

@rtibbles rtibbles mentioned this issue Jun 24, 2022
Merged
9 tasks
@marcellamaki
Copy link
Member Author

Closed with #9535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtibbles rtibbles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtibbles @marcellamaki