Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect folders/resources count when moving from the clipboard #3744

Closed
radinamatic opened this issue Oct 18, 2022 · 9 comments · Fixed by #4631 or #4690
Closed

Incorrect folders/resources count when moving from the clipboard #3744

radinamatic opened this issue Oct 18, 2022 · 9 comments · Fixed by #4631 or #4690
Assignees
Labels
bug P1 - important Priority: High impact on UX

Comments

@radinamatic
Copy link
Member

Observed behavior

While moving a folder with resources from the clipboard to the curator's channel topic tree, the title with summary always stays at 0 folders, 0 resources 👍🏽

incorrect-count-move-from-clipboard

Expected behavior

Title should report the correct number of folders and resources, same as stated at origin (clipboard, 1 folder, 20 resources in the recording above)

User-facing consequences

Uncertainty and confusion about what is being moved from the clipboard.

Errors and logs

Nothing in the console or user-facing.

Steps to reproduce the issue

  1. Select folder/resource in the clipboard
  2. Click on the Move button
  3. Observe the title in the next window

Usage Details

  • OS: Ubuntu 20.04
  • Browser: both Firefox and Chromium
@radinamatic radinamatic added bug P0 - critical Priority: Release blocker or regression labels Oct 18, 2022
@radinamatic
Copy link
Member Author

cc @bjester

@bjester
Copy link
Member

bjester commented Oct 18, 2022

@radinamatic This seems to be an existing issue, so I'm going to downgrade this from P0 to remove this as a release blocker.

@bjester bjester added P1 - important Priority: High impact on UX and removed P0 - critical Priority: Release blocker or regression labels Oct 18, 2022
@bjester bjester self-assigned this Oct 18, 2022
@radinamatic
Copy link
Member Author

My bad for not remembering that, I thought I searched enough...
Agreed it's not a regression then, would the fix be time demanding?

@bjester bjester changed the title Hotfixes - Incorrect folders/resources count when moving fromthe clipboard Incorrect folders/resources count when moving fromthe clipboard Nov 22, 2022
@bjester bjester added this to the Studio: next major release milestone Jan 18, 2023
@bjester bjester changed the title Incorrect folders/resources count when moving fromthe clipboard Incorrect folders/resources count when moving from the clipboard Jun 7, 2023
@bjester
Copy link
Member

bjester commented Jun 20, 2023

This is still extant. Will take a look

@nucleogenesis
Copy link
Member

@LianaHarris360 (cc @marcellamaki @rtibbles)
I'm going to leave some notes behind here re: the clipboard issue.

My branch: https://github.com/nucleogenesis/studio/tree/fix--clipbaord-checkboxes-and-numbers
I fixed a problem w/ checkboxes here. Without this you'll not be able to select anything in the clipboard


I've done a bunch of digging and have a solid lead on what the issue is but I don't know how to fix it correctly. I'd ask Blaine or Richard if I were coming back to this tomorrow, so it might be worth reaching out there.

Issue: When you select items in your Clipboard and then select the "Move" button, the heading of the page is not calculating the number of resources correctly.

Cause (I think): There are two Vuex modules contentNode and clipboard -- both of them keep "maps" (ie, an object mapping ids to the nodes). The id for nodes in the clipboard/clipboardNodesMap is not being loaded into the contentNode/contentNodesMap . The moveHeader is passing in the ids it gets from the clipboard Vuex module, which are used to look up the node's kind in the contentNode/contentNodesMap but... they're not there.


Some notes:

  • The clipboard node source_node_id doesn't map to the id of the contentNode/contentNodeMap
  • The clipboard nodes are not found at all in my IndexedDB -- so perhaps there is something I'm missing altogether there w/ how the backend API would be called?
  • I think that the solution is to get those clipboard nodes' IDs loaded into the contentNode Vuex store. However I think that if you can just get the kinds for the Clipboard nodes you could do the count within the clipboard components/modules

I hope this helps, thank you for taking this on!

@radinamatic
Copy link
Member Author

Still some hickups with how the folders/resources are calculated to display in the modal title: selected resources are always added into the count for folders. For example:

  • when I select 2 resources, the title reports 2 folders, 0 resources
  • when I select a folder with 22 resources, the title reports 23 folders, 0 resources
Select Move
move1 move2

@akolson
Copy link
Member

akolson commented Aug 27, 2024

cc @LianaHarris360

@LianaHarris360
Copy link
Member

I believe I know why this is happening, I'll reopen this issue and get it sorted.

@radinamatic
Copy link
Member Author

Final manual QA on the unstable branch confirms the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment