-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect folders/resources count when moving from the clipboard #3744
Comments
cc @bjester |
@radinamatic This seems to be an existing issue, so I'm going to downgrade this from P0 to remove this as a release blocker. |
My bad for not remembering that, I thought I searched enough... |
This is still extant. Will take a look |
@LianaHarris360 (cc @marcellamaki @rtibbles) My branch: https://github.com/nucleogenesis/studio/tree/fix--clipbaord-checkboxes-and-numbers I've done a bunch of digging and have a solid lead on what the issue is but I don't know how to fix it correctly. I'd ask Blaine or Richard if I were coming back to this tomorrow, so it might be worth reaching out there. Issue: When you select items in your Clipboard and then select the "Move" button, the heading of the page is not calculating the number of resources correctly. Cause (I think): There are two Vuex modules contentNode and clipboard -- both of them keep "maps" (ie, an object mapping ids to the nodes). The id for nodes in the clipboard/clipboardNodesMap is not being loaded into the contentNode/contentNodesMap . The moveHeader is passing in the ids it gets from the clipboard Vuex module, which are used to look up the node's kind in the contentNode/contentNodesMap but... they're not there. Some notes:
I hope this helps, thank you for taking this on! |
I believe I know why this is happening, I'll reopen this issue and get it sorted. |
Final manual QA on the |
Observed behavior
While moving a folder with resources from the clipboard to the curator's channel topic tree, the title with summary always stays at
0 folders, 0 resources
👍🏽Expected behavior
Title should report the correct number of folders and resources, same as stated at origin (clipboard,
1 folder, 20 resources
in the recording above)User-facing consequences
Uncertainty and confusion about what is being moved from the clipboard.
Errors and logs
Nothing in the console or user-facing.
Steps to reproduce the issue
Move
buttonUsage Details
The text was updated successfully, but these errors were encountered: