You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
contentcuration/contentcuration/frontend/accounts/pages/__tests__/create.spec.js fails to run during tests execution when migrated to KCheckbox. It's likely related to the rules and hide-details props that have been removed from the Checkbox.vue component and yet are used in the Create.vue component.
The work around was to use the VCheckbox instead of the Checkbox, since it has the props in question.
Expected behavior
The Create component should be migrated to KCheckbox
The failing tests should run and pass.
User-facing consequences
None
Errors and logs
FAIL contentcuration/contentcuration/frontend/accounts/pages/__tests__/create.spec.js
● Test suite failed to run
Call retries were exceeded
at ChildProcessWorker.initialize (node_modules/jest-worker/build/workers/ChildProcessWorker.js:193:21)
Additional information
We don't need to implement hide-details or rules necessarily. Since this page is the only place where we're using checkbox rules, we can just implement the validation directly in the component. Additionally, it needs to display the error message underneath the field, which hide-details=false allows space for.
bjester
changed the title
accounts/pages/__tests__/create.spec.js fails to run after migrating to KCheckboxCreate.vue needs migrating to KCheckboxMar 29, 2024
I don't think so we need make changes to the KCheckbox component. We can refactor Create.vue to manually check that the Policy checkbox is checked before submitting.
Observed behavior
contentcuration/contentcuration/frontend/accounts/pages/__tests__/create.spec.js
fails to run during tests execution when migrated toKCheckbox
. It's likely related to therules
andhide-details
props that have been removed from theCheckbox.vue
component and yet are used in theCreate.vue
component.studio/contentcuration/contentcuration/frontend/accounts/pages/Create.vue
Lines 135 to 142 in dbb5a63
The work around was to use the
VCheckbox
instead of theCheckbox
, since it has the props in question.Expected behavior
Create
component should be migrated toKCheckbox
User-facing consequences
None
Errors and logs
Additional information
We don't need to implement
hide-details
orrules
necessarily. Since this page is the only place where we're using checkbox rules, we can just implement the validation directly in the component. Additionally, it needs to display the error message underneath the field, whichhide-details=false
allows space for.Steps to reproduce the issue
yarn run test
The text was updated successfully, but these errors were encountered: