Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With rebranded color scheme, card hover state should render box shadow #4547

Closed
bjester opened this issue May 1, 2024 · 1 comment
Closed
Assignees
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@bjester
Copy link
Member

bjester commented May 1, 2024

Observed behavior

When hovering over a channel card, the background turns gray and the color is too dark.

Expected behavior

The hover interaction should match our styleguide for the hover interaction on a KCard, even if the card is using Vuetify. According to the design team, the card should render a box-shadow on hover, meaning the gray background color should be removed.

Additional information

image
KCard spec learningequality/kolibri-design-system#530
https://learningequality.slack.com/archives/C0LKG14NL/p1713310038729639

Usage Details

@bjester bjester added the P0 - critical Priority: Release blocker or regression label May 1, 2024
@bjester bjester added this to the Studio: rebranding patch milestone May 1, 2024
@bjester bjester self-assigned this May 2, 2024
@bjester
Copy link
Member Author

bjester commented May 3, 2024

Closed by #4549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

1 participant