Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cosmetic issues with rebranded cards #4557

Closed
bjester opened this issue May 14, 2024 · 2 comments
Closed

More cosmetic issues with rebranded cards #4557

bjester opened this issue May 14, 2024 · 2 comments
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@bjester
Copy link
Member

bjester commented May 14, 2024

Observed behavior

  • The pinned COVID card at the top of the content library has incorrect hover styling
  • The collection cards are clipped at the bottom by the following cards on hover

Expected behavior

  • The pinned COVID card at the top of the content library has matching hover styling
  • The collection cards do not clip each other so the hover styling (shadow) is visible on all edges of the card

User-facing consequences

Cosmetic inconsistencies look bad

Additional information

Looks great @bjester! Just a couple of questions about whether this change should also be applied to the 'Helpful Resources for Covid-19' card at the top of the Content Library and also whether the hover effect is not good enough when selecting channels for a collection. See the following video:

Yeah the global updates I made somehow missed the COVID card at the top of search. We should make it consistent. As for the collection cards, they were initially flat which posed a problem considering we don't really have flat-hovered card style. At the very least, the cards' bottom shouldn't be clipped by the card below. That said, we should probably switch to a regular card, but as it's coded right now, the checkbox needs to be removed from the card itself, which is a bit out of scope of the rebranding changes.

So I lean towards fixing the current cosmetic issues and followup later with proper update for the collection UI. We can probably accomplish revamping the collection cards when we integrate KCard, to avoid unnecessary dev.

Originally posted by @bjester in #4549 (comment)

@bjester bjester changed the title > Looks great @bjester! Just a couple of questions about whether this change should also be applied to the 'Helpful Resources for Covid-19' card at the top of the Content Library and also whether the hover effect is not good enough when selecting channels for a collection. See the following video: More cosmetic issues with rebranded cards May 14, 2024
@bjester bjester added the P0 - critical Priority: Release blocker or regression label May 14, 2024
@bjester bjester self-assigned this May 14, 2024
@bjester bjester added this to the Studio: rebranding patch milestone May 14, 2024
@bjester
Copy link
Member Author

bjester commented May 21, 2024

Followup issue: #4558

@marcellamaki marcellamaki assigned marcellamaki and unassigned bjester May 21, 2024
@marcellamaki
Copy link
Member

Initial fix resolved in #4574 - the rest tracked in follow up issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

2 participants