Revamp content file mgt #4872
Revamp content file mgt #4872
Conversation
| @@ -680,4 +680,8 @@ | |||
| margin-top: -4px !important; | |||
| } | |||
|
|
|||
| /deep/ .v-dialog__content { | |||
There was a problem hiding this comment.
@rtibbles noting here that linting doesn't seem to recorgnize ::v-deep (Unexpected unknown pseudo-element selector) So reverted to /deep/ for now
akolson
force-pushed
the
revamp-content-file-mgt
branch
from
946addc to
0a2db6f
Compare
akolson
added
TODO: needs review
TAG: ux update
DEV: frontend
and removed
work-in-progress
labels
| @@ -134,6 +131,10 @@ | |||
| 'order' | |||
| ); | |||
| }, | |||
| selectedFilename() { | |||
| const file = this.files.find(f => f.id === this.selected); | |||
| return file ? file.original_filename : ''; | |||
There was a problem hiding this comment.
Any opinion of not using use nullish coalescing here?
| <template #menu> | ||
| <KDropdownMenu | ||
| :options="previewFilesOptions" | ||
| data-test="file-options" |
There was a problem hiding this comment.
You are passing openFileDialog as an argument to every option's onClick handler. But in thepreviewFilesOptions, only the 'REPLACE_FILE' option actually expects that argument? The download and remove options don't need it. I think this can cause other handlers to receive openFileDialog as an unexpected parameter
I assumed when the download option is clicked, this.downloadFile() is called with openFileDialog as an argument. If downloadFile isn't written to handle parameters same applies to removeFile.
|
@akolson Great work here. I just left a few comments |
Summary
This pr revamps tthe content file management UI as described in the figma designs
Before:
After:
Screen.Recording.2025-01-29.at.22.49.20.mov
References
Closes #4840
Reviewer guidance