Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When viewing resource versions, newer and older versions are not visible #53

Open
science opened this issue Aug 30, 2016 · 2 comments
Open

Comments

@science
Copy link
Member

science commented Aug 30, 2016

Mike from Southern Illinois reports that when viewing a historical version of a record, the older and newer versions of the same document are not returned in the result set.

@science science added the bug label Aug 30, 2016
@science science added this to the Backlog milestone Aug 30, 2016
@andersoncardoso
Copy link
Contributor

@science
This behavior is coming from an explicit rule : https://github.com/learningtapestry/metadataregistry/blob/master/app/api/entities/node_headers.rb#L7

I don't know if this was serving some requirement on LR, or if we can remove this now and always show the versions ?

@science
Copy link
Member Author

science commented Sep 13, 2016

I recommend that you ask @aspino if this is there for some particular reason? I could see hiding versions for older "leaf node versions" - makes it less confusing.

I'd suggest instead, we expose all versions "above and below" the current version (or just below for head version). For all non-head version, I suggest we add a flag or something that says "isOlderVersion": true or something to the version information - so the developer can't claim ignorance when looking at an older piece of data (vs holding an old head revision document which wouldn't have that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants