-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need override of NumPy's _isclose_dispatcher (or something) #163
Comments
Honestly, updating the interface to a more modern (and widely available) NumPy/Pandas mechanisms for handling arrays of objects of a different type is something that has been in my mind for a while, so this would be great. I haven't looked closely enough to know whether PS: if you can use PEP 8 for any code submitted to this repository, that'd be useful (because it the end all code here will be PEP 8). I'm saying this because inline comments should have two spaces before PPS: also, including links to the relevant documentation (such as the NumPy/Pandas array interface) in the code would allow me to check that the implementation is the most robust one. :) |
PPPS: and yes, using |
math.isclose
provides this:numpy.isclose
provides its own version, which includes the following implementions:Code to demonstrate problem:
It's kinda wild to think so, but uncertainties needs to override this (to pass some pint_pandas tests). Looking around I see the uarray/unfunc code avoiding array dispatch as a concept (wrapping things instead). Should it continue to avoid, or take the plunge, or?
The text was updated successfully, but these errors were encountered: