-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark_as_read! for ActiveRecord::CollectionProxies #73
Comments
Or, maybe even better, mark_as_read! should be a scope method, then we can mark an entire scope as read. That might even be more efficient since the insertions and selects can be one single query. |
Is there progress? |
Is there a plan of adding this? |
No plan at this moment, but I'm open for a Pull Request. |
Partly done by #93 - an optimized "one query" solution for scopes is still pending. |
Hey, I was implemented it here #95. |
Currently,
Model.mark_as_read!(Model.all.some_scope, for: current_user)
will raise ArgumentError, since the scope is not anArray
. Can it be relaxed so that anyEnumerable
can be used instead?The text was updated successfully, but these errors were encountered: